Pkgconfig #3
Merged
Pkgconfig #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lack of support for .pc files out of the box on OS X is a bit annoying. But I don't think it would be a very hard requirement to ask that people using m4ri install it. |
…ES already provides them to you.
|
Hum there is one more thing that need improvement, wait before merging please. |
|
Not sure what I was thinking. Possibly exchanging one set of issues for another. It can be merged as is. I don't really need an immediate release of that stuff. |
malb
pushed a commit
that referenced
this pull request
Nov 13, 2018
Add functions to print mzd_ts to FILE* streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #2. I added mechanism to incorporate libpng requirements (or lack thereof) in the .pc file. I removed the optimisation flags (but not the SIMD flags) from CFlags.
With this, m4rie and BRiAl shouldn't need to use AX_M4RI_CFLAGS if pkg-config is installed and m4ri.pc can be found.