Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiplication in
mzd_init()
causes a segfault in sagemath on 32 bit.A doctest runs
MatrixSpace(GF(2), 2^30)(1)
expecting to get a memory allocation error, but it doesn't. In fact, thedata
member ends up with amalloc(0)
(notNULL
!) which later causes a segfault. All of this because (2^30) * (2^30/64) is 0 whensize_t
is 32 bits.While looking at this I also noticed that
mzd_init(1, INT_MAX)
aborts (on any architecture), due to another overflow which I also fix here.