Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sanity check for underdetermined systems + add test case #22

Merged
merged 5 commits into from
Nov 25, 2024
Merged

fix sanity check for underdetermined systems + add test case #22

merged 5 commits into from
Nov 25, 2024

Conversation

j-danner
Copy link
Contributor

fixes issue #21 and extends test cases appropriately.

@j-danner
Copy link
Contributor Author

j-danner commented Nov 25, 2024

Now A is padded implicitly with zeros if A->nrows < A->ncols. Only if inconsistency_check=1 we check whether the padding is zero in _mzd_solve_left, and abort early when this is not the case, i.e., the system is obviously inconsistent.
Also this implicit padding is now mentioned in solve.h, but I am unsure if it fits your usual coding style, or it should be put somewhere else. If so, please tell me where to put it, or adapt the PR yourself.

@malb
Copy link
Owner

malb commented Nov 25, 2024

Cool & thank you!

@malb malb merged commit bb78acf into malb:master Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants