Skip to content

Commit

Permalink
remove test
Browse files Browse the repository at this point in the history
Signed-off-by: Meredith Lancaster <[email protected]>
  • Loading branch information
malancas committed Dec 20, 2024
1 parent 719ecf9 commit c23c6e2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
9 changes: 0 additions & 9 deletions pkg/cmd/attestation/verify/verify_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,6 @@ func TestVerifyIntegration(t *testing.T) {
require.ErrorContains(t, err, "expected SourceRepositoryOwnerURI to be https://github.com/fakeowner, got https://github.com/sigstore")
})

t.Run("with invalid owner and invalid repo", func(t *testing.T) {
opts := publicGoodOpts
opts.Repo = "fakeowner/fakerepo"

err := runVerify(&opts, logger, apiClient, ociClient, sigstoreVerifier)
require.Error(t, err)
require.ErrorContains(t, err, "expected SourceRepositoryURI to be https://github.com/fakeowner/fakerepo, got https://github.com/sigstore/sigstore-js")
})

t.Run("with no matching OIDC issuer", func(t *testing.T) {
opts := publicGoodOpts
opts.OIDCIssuer = "some-other-issuer"
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/attestation/verify/verify_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,6 @@ func TestRunVerify(t *testing.T) {
})

t.Run("with missing API client", func(t *testing.T) {
//customOpts.BundlePath = ""
require.Error(t, runVerify(&publicGoodOpts, logger, nil, ociClient, sigstoreVerifier))
})

Expand All @@ -469,7 +468,7 @@ func TestRunVerify(t *testing.T) {
customOpts.ArtifactPath = "oci://ghcr.io/github/test"
customOpts.BundlePath = ""

require.Nil(t, runVerify(&customOpts, logger, apiClient, ociClient, sigstoreVerifier))
require.NoError(t, runVerify(&customOpts, logger, apiClient, ociClient, sigstoreVerifier))
})

t.Run("with valid OCI artifact with UseBundleFromRegistry flag", func(t *testing.T) {
Expand Down

0 comments on commit c23c6e2

Please sign in to comment.