packaging primer #164
packaging primer #164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 89.26% 89.26%
=======================================
Files 30 30
Lines 4303 4303
=======================================
Hits 3841 3841
Misses 462 462 Continue to review full report at Codecov.
|
setup.py
Outdated
| # It ensures open() defaults to text mode with universal newlines, | ||
| # and accepts an argument to specify the text encoding | ||
| # Python 3 only projects can skip this import | ||
| from io import open |
There was a problem hiding this comment.
We can skip this, as we don't support Python 2.7.
There was a problem hiding this comment.
I missed it. Removed
setup.py
Outdated
| # For a discussion on single-sourcing the version across setup.py and the | ||
| # project code, see | ||
| # https://packaging.python.org/en/latest/single_source_version.html | ||
| version='1.0.4', # Required |
There was a problem hiding this comment.
Curious how version was determined, and how we should update it going forward.
There was a problem hiding this comment.
Pulled it from cf515c9 but I'm not sure of coupling pymaker versioning to MCD releases is future-proof.
For now this doesn't publish anywhere, but happy to take this further and set up pypi for this and other pkgs lilke the auction-keeper. |
|
I think there's value adding this to PyPI. I'd just like to understand how we'll push new releases. Is that something techops would handle, or will other contributors within the foundation be able to push? Maybe we should start the version at 1.0.0? |
makes pymaker available as a python package, so it can be installed via pip or included in a project's requirements file. e.g: