fix: align plugin.json name with marketplace.json entry#17
Open
miky-mfw wants to merge 1 commit intomakenotion:mainfrom
Open
fix: align plugin.json name with marketplace.json entry#17miky-mfw wants to merge 1 commit intomakenotion:mainfrom
miky-mfw wants to merge 1 commit intomakenotion:mainfrom
Conversation
The plugin.json declares "name": "Notion" but marketplace.json declares "name": "notion-workspace-plugin". This mismatch causes plugin update and info lookups to fail with "Plugin Notion not found in marketplace". Fixes makenotion#16
miky-mfw
force-pushed
the
fix/plugin-name-mismatch
branch
from
a57792a to
4e53495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin.json"name"field ("Notion") withmarketplace.jsonplugin entry ("notion-workspace-plugin")/pluginupdate and info lookups to fail with"Plugin Notion not found in marketplace"Root Cause
The
/pluginmenu resolves plugins by the marketplace-level name (notion-workspace-plugin), but displays the name fromplugin.json(Notion). When triggering update/info, it looks up"Notion"and can't find a match.Fixes #16