Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cell comment #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pshriwise
Copy link
Contributor

Ran into a case where a line containing only a comment character, 'c' is treated as a cell.

This happens with a section in the cell cards that looks something like.

...
 4980  131 0.06026342    8085  -8086   8654  -4684  27  100 -200 imp:n=1 
 4985  133 0.06000038     8011  -8086   4684  -4682  27  100 -200 imp:n=1
 4995  130 0.099591    8011  -8086   4682  -53    27  100 -200 imp:n=1
c
c      Comment line sandwiched by two blank comment lines
c
 5001  130 0.099591    7511  -7586   -67 7602  -53  100 -200 imp:n=1
 5002  133 0.06000038    7511  -7586   -7602  7604  -53  100 -200 imp:n=1 
...

Sorry for all the whitespace changes. The only actual change I made is at line 799.

This seemed to do the trick for me

@shimwell
Copy link
Collaborator

Sorry for the delay I just noticed this PR while doing some spring cleaning, I shall make a test to check this behavior then I think we can merge it.

@shimwell
Copy link
Collaborator

I can't quite reproduce the error you were getting, I wrote a test for the example problem but I guess it is not reproducing your situation correctly #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants