Stop attempting to synchronise media files from database if the media…

[hostep]

… storage is configured to use the filesystem.

Description (*)

When media storage is on the local filesystem, and you try to request a non-existing file, an unwanted database query is send to the media_storage_file_storage database table, which will fail because the table doesn't exist.

This PR prevents this by avoiding this unnecessary database query.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes SELECT from media_storage_file_storage when media DB storage is not in use or disabled #38116

Manual testing scenarios (*)

1. Setup a clean Magento install
2. Ensure the config setting 'Stores > Configuration > Advanced > System > Storage Configuration for Media > Media Storage' is set to File System (the default)
3. Ensure the database does not have a table media_storage_file_storage
4. Enable query logging: bin/magento dev:query-log:enable --include-all-queries=true --include-call-stack=true
5. Temporarily add a var_dump debug line on this line:

--- a/app/code/Magento/MediaStorage/Model/File/Storage/Synchronization.php
+++ b/app/code/Magento/MediaStorage/Model/File/Storage/Synchronization.php
@@ -72,6 +72,7 @@ class Synchronization
         try {
             $storage->loadByFilename($relativeFileName);
         } catch (\Exception $e) { // phpcs:ignore Magento2.CodeAnalysis.EmptyBlock.DetectedCatch
+            var_dump($e);
         }
         if ($storage->getId()) {
             /** @var WriteInterface $file */

6. In your browser try to request a non-existing image, for example: https://my-domain-name.local/media/wysiwyg/non-existing-image.png
7. Expected is to not see the var_dump output in your browser and to not see queries in the var/debug/db.log going to the table media_storage_file_storage
8. Double check if when you switch the media storage to Database (deprecated), this feature still functions as expected and this PR isn't introducing a regression there

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

@magento run all tests