Skip to content

Conversation

@lbajsarowicz
Copy link
Contributor

Description (*)

Cast website and store IDs to int in EmailNotification::getWebsiteStoreId() so the return value matches the declared int return type when StoreManager/Website return IDs as strings.

Fixed Issues (if relevant)

Fixes #40469

Manual testing scenarios (*)

  1. Create a custom module that sends welcome email via Magento\Customer\Model\EmailNotification::newAccount($customer).
  2. Trigger welcome email (e.g. after customer registration or programmatically).
  3. Verify no type error: "Return value must be of type int, string returned" and that the email is sent.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

…magento#40469)

StoreManager/Website return store and website ids as strings while
EmailNotification::getWebsiteStoreId() declares int return type, causing
a type error when sending welcome emails via newAccount().
@lbajsarowicz lbajsarowicz force-pushed the fix/40469-email-notification-website-store-id-type branch from 4ab9627 to e6de471 Compare January 31, 2026 12:34
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website and Store objects return ids as strings

1 participant