Skip to content

Product Repository - Adds SKU or ID into the exception message #40091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

asim-blueprintprep
Copy link
Contributor

Description (*)

This MR adds the requested SKU or ID to the exception error log for the ProductRepository class. This will help give context to error logs when debugging, to figure out what was requested and how to solve.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Extra Logging When Requesting A Product Via Repository Fails #40090

Manual testing scenarios (*)

  1. Add Magento\Catalog\Api\ProductRepositoryInterface to a DI or ObjectManager, or make an authenticated rest rest/V1/products/:product request
  2. Request an invalid SKU or ID
  3. The error message should now contain the requested SKU or ID.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [] All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jul 21, 2025

Hi @asim-blueprintprep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@asim-blueprintprep asim-blueprintprep changed the title Product Repository - Adds SKU or ID into the exception error log message for more context when debugging Product Repository - Adds SKU or ID into the exception message Jul 21, 2025
@asim-blueprintprep
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 22, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

Extra Logging When Requesting A Product Via Repository Fails
2 participants