Skip to content

Improve performance of the Category page #40082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

Genaker
Copy link
Contributor

@Genaker Genaker commented Jul 21, 2025

Lazy load all images except 1. Lazy load negatively impacts LCP metric you shouldn't lazy load LCP element for category it is first image if no big image in the description. We are adding global counter

Resolved issues:

  1. resolves [Issue] Improve performance of the Category page #40087: Improve performance of the Category page

Lazy load all images except 1. Lazy load negatively impacts LCP metric you shouldn't lazy load LCP element for category it is first image if no big image in the description. We are adding global counter
Copy link

m2-assistant bot commented Jul 21, 2025

Hi @Genaker. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -11,6 +11,12 @@
$width = (int)$block->getWidth();
$height = (int)$block->getHeight();
$paddingBottom = $block->getRatio() * 100;

if (!isset($_GET['cat_image'])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Direct call to global variables is unacceptable. Please use RequestInterface to access request params.

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Jul 21, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 21, 2025
@engcom-Hotel
Copy link
Contributor

@magento create issue

@@ -11,6 +11,12 @@
$width = (int)$block->getWidth();
$height = (int)$block->getHeight();
$paddingBottom = $block->getRatio() * 100;

if (!isset($_GET['cat_image'])) {
$_GET['cat_image'] = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Modifying global variables such as $_GET or $_POST, including operations that indirectly change their values (e.g., incrementation), is considered unacceptable.

@Genaker
Copy link
Contributor Author

Genaker commented Jul 23, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

[Issue] Improve performance of the Category page
4 participants