Skip to content

magento/magento2#32679: setup:upgrade --dry-run does not work as expected by other dry-run-commands in Linux-environment #33332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#32679: setup:upgrade --dry-run does not work as expected by other dry-run-commands in Linux-environment #33332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9cbc69c
magento/magento2#32679: setup:upgrade --dry-run does not work as expe…
4ctobias Jun 24, 2021
93d1a50
magento/magento2#32679: setup:upgrade --dry-run does not work as expe…
4ctobias Jul 1, 2021
12b081a
Merge branch '2.4-develop' into fix-32679-dry-run
4ctobias Jul 1, 2021
878e480
magento/magento2#32679: setup:upgrade --dry-run does not work as expe…
4ctobias Jul 1, 2021
e17c09a
Merge branch 'fix-32679-dry-run' of https://github.com/4ctobias/magen…
4ctobias Jul 1, 2021
04e9ced
Merge branch '2.4-develop' into fix-32679-dry-run
4ctobias Nov 18, 2021
2d1183c
Merge branch '2.4-develop' into fix-32679-dry-run
4ctobias Mar 25, 2022
215b398
Merge branch '2.4-develop' into fix-32679-dry-run
engcom-Dash Oct 3, 2024
9e19354
33332: Fix PHPCS error related to deprecation tag
engcom-Dash Oct 4, 2024
66e3525
Merge branch '2.4-develop' into fix-32679-dry-run
engcom-Dash Oct 14, 2024
49a96c0
Merge branch '2.4-develop' into fix-32679-dry-run
engcom-Dash Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dev/tests/setup-integration/framework/Magento/TestFramework/Deploy/CliCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ public function disableModule($moduleName)
* @return void
* @throws LocalizedException
* @deprecated split database solution is deprecated and will be removed
* @see Nothing
*/
public function splitQuote()
{
Expand All @@ -141,6 +142,7 @@ public function splitQuote()
* @return void
* @throws LocalizedException
* @deprecated split database solution is deprecated and will be removed
* @see Nothing
*/
public function splitSales()
{
Expand Down Expand Up @@ -199,7 +201,9 @@ private function toCliArguments(array $params)
$result = [];

foreach ($params as $key => $value) {
if (!empty($value)) {
if ($value === $key) {
$result["--{$key}"] = null;
} elseif (!empty($value)) {
$result["--{$key}=%s"] = $value;
}
}
Expand Down
4 changes: 2 additions & 2 deletions dev/tests/setup-integration/testsuite/Magento/Setup/DryRunTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function testDryRunOnCleanDatabase()
$logFileName = TESTS_TEMP_DIR . '/var/log/' . DryRunLogger::FILE_NAME;
$this->cliCommad->install(
['Magento_TestSetupDeclarationModule1'],
['dry-run' => true]
['dry-run' => 'dry-run']
);
self::assertFileExists($logFileName);
$data = file_get_contents($logFileName);
Expand All @@ -64,7 +64,7 @@ public function testDryRunOnUpgrade()
'db_schema.xml',
'etc'
);
$this->cliCommad->upgrade(['dry-run' => true]);
$this->cliCommad->upgrade(['dry-run' => 'dry-run']);
self::assertFileExists($logFileName);
$data = file_get_contents($logFileName);
self::assertEquals($this->getData()[0], $data);
Expand Down
5 changes: 2 additions & 3 deletions setup/src/Magento/Setup/Console/Command/InstallCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,8 @@ protected function configure()
new InputOption(
DryRunLogger::INPUT_KEY_DRY_RUN_MODE,
null,
InputOption::VALUE_OPTIONAL,
'Magento Installation will be run in dry-run mode',
false
InputOption::VALUE_NONE,
'Magento Installation will be run in dry-run mode'
),
]);
$this->setName('setup:install')
Expand Down
5 changes: 2 additions & 3 deletions setup/src/Magento/Setup/Console/Command/UpgradeCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,8 @@ protected function configure()
new InputOption(
DryRunLogger::INPUT_KEY_DRY_RUN_MODE,
null,
InputOption::VALUE_OPTIONAL,
'Magento Installation will be run in dry-run mode',
false
InputOption::VALUE_NONE,
'Magento Installation will be run in dry-run mode'
)
];
$this->setName('setup:upgrade')
Expand Down