-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix webapi returns variables in JSON using snake case and I need camelCase #25180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @jayankaghosh. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
Hi @jayankaghosh, I'll take this PR and will provide my feedback soon. From the first look - in general changes looks good to me, but some adjustments definitely will be required. |
Oh... I see that the branch from which was created this PR was already removed, so we basically can't accept this PR. Unfortunately I have to close this PR due to that reason. If you're still interesting in contributing this improvement - please create a new PR with the same changes, I'll try to take it as fast as possible. |
Hi @jayankaghosh, thank you for your contribution! |
@jayankaghosh could you create a new pull request base on current one. |
@tuyennn Oh my. I forgot I've even made this PR. Lol. Sure. I'll create a new PR at the earliest. |
@ihor-sviziev @tuyennn Here's the new PR |
Description (*)
Added objectKeyMap which accepts parameters from di.xml to modify data object keys
We can now modify the keys of any accessor on any class used in the rendering of the REST API, using the following (or similar) snippet in the
di.xml
of thewebapi_rest
directory.Fixed Issues (if relevant)
Manual testing scenarios (*)
di.xml
insidewebapi_rest
directory of any module and inject object key names to it, similar to the followingContribution checklist (*)