Make MC-43048 available for 2.4.3-p1 by arnoudhgz · Pull Request #84 · magento/magento-cloud-patches

arnoudhgz · 2021-11-10T11:33:33Z

The rate limit patch is still needed in the latest Magento version 2.4.3-p1, but was not listed anymore for that version.

Manual testing scenarios

Locally install Magento Cloud version 2.4.3-p1
See if the patch is listed with vendor/bin/ece-patches status
Add the patch in .magento.env.yaml
Apply the patch with vendor/bin/ece-patches apply

Contribution checklist

Pull request has a meaningful description of its purpose
Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)

- Added LICENSE.TXT - Added COPYING.TXT - Updated README.md

MAGECLOUD-4442: Deliver fix for mail interfaces

…hes (magento#10)

Merge develop into 1.0

)

MAGECLOUD-4982: De-composed magento-cloud-patches fail to apply locally

MAGECLOUD-4979: Cleanup Composer Dependencies

…rs (magento#17)

Bump Composer version to 1.0.1

…into MAGECLOUD-5215 � Conflicts: � composer.json

MAGECLOUD-5215: Forward-port delivered changes

…to#24)

… patches multiple times (magento#25)

…er dependencies conflict (magento#26)

)

… happens during a patch applying (magento#43)

…duct page). (magento#45)

The rate limit patch is still needed in the latest Magento version 2.4.3-p1, but was not listed anymore for that version.

magento-cloud-ft-jenkins-svc · 2021-11-10T11:40:01Z

Unit Test Results

✅ All unit tests have passed.

Unit Test Output

> phpunit --configuration tests/unit '--log-junit' 'tests/unit/tmp/junit.xml' '--coverage-clover' 'tests/unit/tmp/clover.xml'
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

...............................................................  63 / 161 ( 39%)
............................................................... 126 / 161 ( 78%)
...................................                             161 / 161 (100%)

Time: 1.88 seconds, Memory: 18.00 MB

OK (161 tests, 397 assertions)

Generating code coverage report in Clover XML format ... done

This comment was generated by Jenkins job magento-cloud-patches/unit build 47.

magento-cloud-ft-jenkins-svc · 2021-11-10T11:40:07Z

Static Analysis & Code Style Results

✅ All static analysis and code style checks have passed.

PHP Codesniffer Output

> phpcs src --standard=tests/static/phpcs-ruleset.xml -p -n
............................................................  60 / 154 (39%)
............................................................ 120 / 154 (78%)
..................................                           154 / 154 (100%)


Time: 5.23 secs; Memory: 12MB

PHP Mess Detector Output


Found 0 violations and 0 errors in 3317ms

�[32mNo mess detected�[0m

This comment was generated by Jenkins job magento-cloud-patches/static build 48.

magento-cloud-ft-jenkins-svc · 2021-11-10T14:07:12Z

Functional Acceptance Test Results

❌ One or more functional acceptance tests have failed.

PHP 7.2

✅ Acceptance72Cest
✅ Acceptance72CeCest

PHP 7.3

✅ Acceptance73CeCest
✅ Acceptance73Cest

PHP 7.4

✅ PatchApplierCest
❌ AcceptanceCeCest
✅ AcceptanceCest

Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details.

This comment was generated by Jenkins job magento-cloud-patches/functional build 83.

magento-cloud-ft-jenkins-svc · 2021-11-10T14:07:13Z

PHP 7.4 AcceptanceCeCest Output

Codeception PHP Testing Framework v2.5.6
Powered by PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
Running with seed: 


Acceptance Tests (10) --------------------------------------
AcceptanceCeCest: Test patches | "2.4.0","2.4.0"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.0"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.4.0"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.0","2.4.0-p1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.0"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.0-p1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.1","2.4.1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.1"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.4.1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.1","2.4.1-p1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.1"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.1-p1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.2","2.4.2"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.4.2"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.2","2.4.2-p1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.2-p1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.2","2.4.2-p2"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.2-p2"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.3","2.4.3"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.3"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.4.3"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true false
 I stop environment 
 I remove work dir 
 FAIL 

------------------------------------
Message: Failed asserting that false is true.
------------------------------------
Stack Trace: 
#0 /app/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php(60): PHPUnit\Framework\Constraint\Constraint->fail(false, '')
#1 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(2307): PHPUnit\Framework\Constraint\Constraint->evaluate(false, '')
#2 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(1156): PHPUnit\Framework\Assert::assertThat(false, Object(PHPUnit\Framework\Constraint\IsTrue), '')
#3 /app/vendor/codeception/codeception/src/Codeception/Util/Shared/Asserts.php(267): PHPUnit\Framework\Assert::assertTrue(false, '')
#4 /app/vendor/codeception/codeception/src/Codeception/Module/Asserts.php(263): Codeception\Module->assertTrue(false, '')
#5 [internal function]: Codeception\Module\Asserts->assertTrue(false)
#6 /app/vendor/codeception/codeception/src/Codeception/Step.php(265): call_user_func_array(Array, Array)
#7 /app/vendor/codeception/codeception/src/Codeception/Scenario.php(72): Codeception\Step->run(Object(Codeception\Lib\ModuleContainer))
#8 /app/vendor/magento/magento-cloud-docker/tests/functional/_support/_generated/CliTesterActions.php(3534): Codeception\Scenario->runStep(Object(Codeception\Step\Action))
#9 /app/src/Test/Functional/Acceptance/AcceptanceCest.php(39): CliTester->assertTrue(false)
#10 [internal function]: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCest->testPatches(Object(CliTester), Object(Codeception\Example))
#11 /app/vendor/codeception/codeception/src/Codeception/Lib/Di.php(127): ReflectionMethod->invokeArgs(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), Array)
#12 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(138): Codeception\Lib\Di->injectDependencies(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), 'testPatches', Array)
#13 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(147): Codeception\Test\Cest->invoke('testPatches', Array)
#14 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(82): Codeception\Test\Cest->executeTestMethod(Object(CliTester))
#15 /app/vendor/codeception/codeception/src/Codeception/Test/Test.php(89): Codeception\Test\Cest->test()
#16 /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php(746): Codeception\Test\Test->run(Object(PHPUnit\Framework\TestResult))
#17 /app/vendor/codeception/phpunit-wrapper/src/Runner.php(118): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#18 /app/vendor/codeception/codeception/src/Codeception/SuiteManager.php(158): Codeception\PHPUnit\Runner->doEnhancedRun(Object(Codeception\Suite), Object(PHPUnit\Framework\TestResult), Array)
#19 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(192): Codeception\SuiteManager->run(Object(Codeception\PHPUnit\Runner), Object(PHPUnit\Framework\TestResult), Array)
#20 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(159): Codeception\Codecept->runSuite(Array, 'Acceptance', 'AcceptanceCeCes...')
#21 /app/vendor/codeception/codeception/src/Codeception/Command/Run.php(384): Codeception\Codecept->run('Acceptance', 'AcceptanceCeCes...', Array)
#22 /app/vendor/symfony/console/Command/Command.php(255): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#23 /app/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#24 /app/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#25 /app/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /app/vendor/codeception/codeception/src/Codeception/Application.php(108): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /app/vendor/codeception/codeception/codecept(43): Codeception\Application->run()
#28 {main}
------------------------------------
AcceptanceCeCest: Test patches | "2.4.3","2.4.3-p1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.3"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.3-p1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true false
 I stop environment 
 I remove work dir 
 FAIL 

------------------------------------
Message: Failed asserting that false is true.
------------------------------------
Stack Trace: 
#0 /app/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php(60): PHPUnit\Framework\Constraint\Constraint->fail(false, '')
#1 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(2307): PHPUnit\Framework\Constraint\Constraint->evaluate(false, '')
#2 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(1156): PHPUnit\Framework\Assert::assertThat(false, Object(PHPUnit\Framework\Constraint\IsTrue), '')
#3 /app/vendor/codeception/codeception/src/Codeception/Util/Shared/Asserts.php(267): PHPUnit\Framework\Assert::assertTrue(false, '')
#4 /app/vendor/codeception/codeception/src/Codeception/Module/Asserts.php(263): Codeception\Module->assertTrue(false, '')
#5 [internal function]: Codeception\Module\Asserts->assertTrue(false)
#6 /app/vendor/codeception/codeception/src/Codeception/Step.php(265): call_user_func_array(Array, Array)
#7 /app/vendor/codeception/codeception/src/Codeception/Scenario.php(72): Codeception\Step->run(Object(Codeception\Lib\ModuleContainer))
#8 /app/vendor/magento/magento-cloud-docker/tests/functional/_support/_generated/CliTesterActions.php(3534): Codeception\Scenario->runStep(Object(Codeception\Step\Action))
#9 /app/src/Test/Functional/Acceptance/AcceptanceCest.php(39): CliTester->assertTrue(false)
#10 [internal function]: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCest->testPatches(Object(CliTester), Object(Codeception\Example))
#11 /app/vendor/codeception/codeception/src/Codeception/Lib/Di.php(127): ReflectionMethod->invokeArgs(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), Array)
#12 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(138): Codeception\Lib\Di->injectDependencies(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), 'testPatches', Array)
#13 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(147): Codeception\Test\Cest->invoke('testPatches', Array)
#14 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(82): Codeception\Test\Cest->executeTestMethod(Object(CliTester))
#15 /app/vendor/codeception/codeception/src/Codeception/Test/Test.php(89): Codeception\Test\Cest->test()
#16 /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php(746): Codeception\Test\Test->run(Object(PHPUnit\Framework\TestResult))
#17 /app/vendor/codeception/phpunit-wrapper/src/Runner.php(118): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#18 /app/vendor/codeception/codeception/src/Codeception/SuiteManager.php(158): Codeception\PHPUnit\Runner->doEnhancedRun(Object(Codeception\Suite), Object(PHPUnit\Framework\TestResult), Array)
#19 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(192): Codeception\SuiteManager->run(Object(Codeception\PHPUnit\Runner), Object(PHPUnit\Framework\TestResult), Array)
#20 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(159): Codeception\Codecept->runSuite(Array, 'Acceptance', 'AcceptanceCeCes...')
#21 /app/vendor/codeception/codeception/src/Codeception/Command/Run.php(384): Codeception\Codecept->run('Acceptance', 'AcceptanceCeCes...', Array)
#22 /app/vendor/symfony/console/Command/Command.php(255): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#23 /app/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#24 /app/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#25 /app/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /app/vendor/codeception/codeception/src/Codeception/Application.php(108): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /app/vendor/codeception/codeception/codecept(43): Codeception\Application->run()
#28 {main}
------------------------------------
AcceptanceCeCest: Test patches | "master"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "master"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I get work dir path 
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/p...",">=2.4.3 <..."
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true false
 I stop environment 
 I remove work dir 
 FAIL 

------------------------------------
Message: Failed asserting that false is true.
------------------------------------
Stack Trace: 
#0 /app/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php(60): PHPUnit\Framework\Constraint\Constraint->fail(false, '')
#1 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(2307): PHPUnit\Framework\Constraint\Constraint->evaluate(false, '')
#2 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(1156): PHPUnit\Framework\Assert::assertThat(false, Object(PHPUnit\Framework\Constraint\IsTrue), '')
#3 /app/vendor/codeception/codeception/src/Codeception/Util/Shared/Asserts.php(267): PHPUnit\Framework\Assert::assertTrue(false, '')
#4 /app/vendor/codeception/codeception/src/Codeception/Module/Asserts.php(263): Codeception\Module->assertTrue(false, '')
#5 [internal function]: Codeception\Module\Asserts->assertTrue(false)
#6 /app/vendor/codeception/codeception/src/Codeception/Step.php(265): call_user_func_array(Array, Array)
#7 /app/vendor/codeception/codeception/src/Codeception/Scenario.php(72): Codeception\Step->run(Object(Codeception\Lib\ModuleContainer))
#8 /app/vendor/magento/magento-cloud-docker/tests/functional/_support/_generated/CliTesterActions.php(3534): Codeception\Scenario->runStep(Object(Codeception\Step\Action))
#9 /app/src/Test/Functional/Acceptance/AcceptanceCest.php(39): CliTester->assertTrue(false)
#10 [internal function]: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCest->testPatches(Object(CliTester), Object(Codeception\Example))
#11 /app/vendor/codeception/codeception/src/Codeception/Lib/Di.php(127): ReflectionMethod->invokeArgs(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), Array)
#12 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(138): Codeception\Lib\Di->injectDependencies(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), 'testPatches', Array)
#13 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(147): Codeception\Test\Cest->invoke('testPatches', Array)
#14 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(82): Codeception\Test\Cest->executeTestMethod(Object(CliTester))
#15 /app/vendor/codeception/codeception/src/Codeception/Test/Test.php(89): Codeception\Test\Cest->test()
#16 /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php(746): Codeception\Test\Test->run(Object(PHPUnit\Framework\TestResult))
#17 /app/vendor/codeception/phpunit-wrapper/src/Runner.php(118): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#18 /app/vendor/codeception/codeception/src/Codeception/SuiteManager.php(158): Codeception\PHPUnit\Runner->doEnhancedRun(Object(Codeception\Suite), Object(PHPUnit\Framework\TestResult), Array)
#19 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(192): Codeception\SuiteManager->run(Object(Codeception\PHPUnit\Runner), Object(PHPUnit\Framework\TestResult), Array)
#20 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(159): Codeception\Codecept->runSuite(Array, 'Acceptance', 'AcceptanceCeCes...')
#21 /app/vendor/codeception/codeception/src/Codeception/Command/Run.php(384): Codeception\Codecept->run('Acceptance', 'AcceptanceCeCes...', Array)
#22 /app/vendor/symfony/console/Command/Command.php(255): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#23 /app/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#24 /app/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#25 /app/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /app/vendor/codeception/codeception/src/Codeception/Application.php(108): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /app/vendor/codeception/codeception/codecept(43): Codeception\Application->run()
#28 {main}
------------------------------------
------------------------------------------------------------
713x DEPRECATION: Calling the "Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch()" method with the event name as the first argument is deprecated since Symfony 4.3, pass it as the second argument and provide the event object as the first argument instead. /app/vendor/symfony/event-dispatcher/EventDispatcher.php:58
207x DEPRECATION: Passing a command as string when creating a "Symfony\Component\Process\Process" instance is deprecated since Symfony 4.2, pass it as an array of its arguments instead, or use the "Process::fromShellCommandline()" constructor if you need features provided by the shell. /app/vendor/symfony/process/Process.php:147
110x DEPRECATION: The Robo\Common\ProcessUtils::escapeArgument() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0. /app/vendor/consolidation/robo/src/Common/ProcessUtils.php:39
14x DEPRECATION: The "Symfony\Component\BrowserKit\Response::getStatus()" method is deprecated since Symfony 4.3, use getStatusCode() instead. /app/vendor/symfony/browser-kit/Response.php:100
3x DEPRECATION: Calling the "Codeception\Lib\Connector\Guzzle6::getInternalResponse()" method before the "request()" one is deprecated since Symfony 4.1 and will throw an exception in 5.0. /app/vendor/symfony/browser-kit/Client.php:217


Time: 1.92 hours, Memory: 26.00 MB

There were 3 failures:

---------
1) AcceptanceCeCest: Test patches | "2.4.3","2.4.3"
 Test  src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
 Step  Assert true false
 Fail  Failed asserting that false is true.

Scenario Steps:

 32. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:101
 31. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:100
 30. $I->assertTrue(false) at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 29. $I->runDockerComposeCommand("run deploy cloud-deploy") at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 28. $I->assertTrue(true) at src/Test/Functional/Acceptance/AcceptanceCest.php:38
 27. $I->startEnvironment() at src/Test/Functional/Acceptance/AcceptanceCest.php:38


---------
2) AcceptanceCeCest: Test patches | "2.4.3","2.4.3-p1"
 Test  src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
 Step  Assert true false
 Fail  Failed asserting that false is true.

Scenario Steps:

 32. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:101
 31. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:100
 30. $I->assertTrue(false) at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 29. $I->runDockerComposeCommand("run deploy cloud-deploy") at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 28. $I->assertTrue(true) at src/Test/Functional/Acceptance/AcceptanceCest.php:38
 27. $I->startEnvironment() at src/Test/Functional/Acceptance/AcceptanceCest.php:38


---------
3) AcceptanceCeCest: Test patches | "master"
 Test  src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
 Step  Assert true false
 Fail  Failed asserting that false is true.

Scenario Steps:

 33. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:101
 32. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:100
 31. $I->assertTrue(false) at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 30. $I->runDockerComposeCommand("run deploy cloud-deploy") at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 29. $I->assertTrue(true) at src/Test/Functional/Acceptance/AcceptanceCest.php:38
 28. $I->startEnvironment() at src/Test/Functional/Acceptance/AcceptanceCest.php:38


FAILURES!
Tests: 10, Assertions: 51, Failures: 3.
- XML report generated in file:///app/tests/functional/_output/junit.xml

This comment was generated by Jenkins job magento-cloud-patches/functional build 83.

MCLOUD-11143: Return MCLOUD-10604 patch back with updated constraints

mmansoor-magento and others added 30 commits October 16, 2019 09:51

Initial commit

f13fad4

Add License & Update Readme (magento#1)

ddf9889

- Added LICENSE.TXT - Added COPYING.TXT - Updated README.md

MAGECLOUD-4458: De-compose All Patches from ECE-Tools (magento#2)

173ee29

MAGECLOUD-4442: Deliver fix for mail interfaces

2914e4e

Merge pull request magento#3 from magento/MAGECLOUD-4442

5639587

MAGECLOUD-4442: Deliver fix for mail interfaces

MAGECLOUD-4448-4449: Deliver core patches (magento#4)

5d1b009

MAGECLOUD-4585: Reduce q-ty of Reports Created in /app/*/var/report (m…

3b0fee2

…agento#5)

MAGECLOUD-4649: Merge PageBuilder Security Patches to m-cloud-patches (…

93cc54f

…magento#6)

MAGECLOUD-4661: Security-only Releases Broke Cloud Patching Process (m…

2c776c0

…agento#7)

MAGECLOUD-4845: Patch applying is failing on installation from git (m…

382df44

…agento#9)

MAGECLOUD-4606: Review Hotfixes List and Add All Missing for 2.1.4+ (m…

7251aa9

…agento#8)

MAGECLOUD-4847: Issues caused by MC-21696 hot fix from ece-tools patc…

b593939

…hes (magento#10)

MAGECLOUD-4884: Update PageBuilder Patches for RCE (magento#11)

7eb8f4a

Merge pull request magento#12 from magento/develop

bd0366b

Merge develop into 1.0

MAGECLOUD-4980: Pagebuilder patches fail CE functional tests (magento#14

9524c87

)

Add v2.8 of Symfony packages

0a22b2a

MAGECLOUD-4982: De-composed magento-cloud-patches fail to apply locally

b5937b7

Merge pull request magento#15 from magento/MAGECLOUD-4982

11e4fe7

MAGECLOUD-4982: De-composed magento-cloud-patches fail to apply locally

Minimize dependency set a bit

db90801

Merge branch '1.0' into MAGECLOUD-4979

e88f26b

Add legacy version of symfony/config for PHP 7.0

f7806a6

Add support for ^3.3 version of symfony/dependency-injection

7db5340

Allow symfony/config 3.3 instead of 2.8

06f0896

MAGECLOUD-4979: Cleanup Composer Dependencies

6c5d8ce

MAGECLOUD-4979: Cleanup Composer Dependencies

MAGECLOUD-4530: Create patch for deadlocks related to crons / consume…

5b5594d

…rs (magento#17)

Bump Composer version to 1.0.1

7a1bb07

Merge pull request magento#18 from magento/shiftedreality-patch-1

088d258

Bump Composer version to 1.0.1

MAGECLOUD-5127: Update Constraints for Magento 2.4 (magento#19)

02222f9

Merge branch '1.0' of https://github.com/magento/magento-cloud-patches …

32c6d82

…into MAGECLOUD-5215 � Conflicts: � composer.json

Merge pull request magento#20 from magento/MAGECLOUD-5215

1da64c2

MAGECLOUD-5215: Forward-port delivered changes

o-dubovyk and others added 15 commits April 14, 2021 11:59

MCLOUD-7742: Updated patch to fix the layered navigation issue (magen…

30594d7

…to#24)

MC-41912: 'magento-patches apply' command doesn't allow to apply some…

f1355ef

… patches multiple times (magento#25)

MC-42131: MCP can't be installed with Magento 2.3.7 due to the compos…

c32358a

…er dependencies conflict (magento#26)

MCLOUD-7827: Error on Search page after switching Store View (magento#31

82f12cd

)

Community patches & Category support (magento#30)

e334c98

MCLOUD-8053: Release Cloud Tools (magento#32)

3410bcc

MCLOUD-8053: Release Cloud Tools

494afc9

Merge pull request magento#36 from magento-commerce/MCLOUD-8053

f502162

MC-42674 (magento#35)

4c9ea73

MC-43048 (magento#38)

3498b37

AC-384: Fix Incompatible PHP Method (magento#42)

723e283

ACP2E-138: PHP error 'Undefined variable: errorMessage' when conflict…

6f63cb3

… happens during a patch applying (magento#43)

ACMP-1263: Update Monolog (magento#41)

e525467

MCLOUD-8279: Added MDVA-40924 patch (Fixed currency displaying on pro…

71650c8

…duct page). (magento#45)

Make MC-43048 available for 2.4.3-p1

b144959

The rate limit patch is still needed in the latest Magento version 2.4.3-p1, but was not listed anymore for that version.

m2-community-project Bot added the Progress: ready for review label Nov 10, 2021

michaelcasey316 assigned BaDos Jun 22, 2022

m2-community-project Bot added Progress: review PR/issue status and removed Progress: ready for review labels Jun 22, 2022

magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 11, 2023

Merge pull request #84 from magento-commerce/MCLOUD-11143

712bb26

MCLOUD-11143: Return MCLOUD-10604 patch back with updated constraints

BaDos removed their assignment Mar 2, 2024

m2-community-project Bot added Progress: ready for review and removed Progress: review PR/issue status labels Mar 2, 2024

andriyShevtsov closed this Sep 8, 2025

andriyShevtsov force-pushed the develop branch from 7f46bdf to 6e03ab1 Compare September 8, 2025 13:20

andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025

Merge pull request #84 from magento-commerce/MCLOUD-11143

a31dcee

MCLOUD-11143: Return MCLOUD-10604 patch back with updated constraints

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make MC-43048 available for 2.4.3-p1#84

Make MC-43048 available for 2.4.3-p1#84
arnoudhgz wants to merge 135 commits intomagento:developfrom
arnoudhgz:feature/2-4-3-p1-ratelimit

arnoudhgz commented Nov 10, 2021

Uh oh!

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Uh oh!

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Uh oh!

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Uh oh!

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

arnoudhgz commented Nov 10, 2021

Manual testing scenarios

Contribution checklist

Uh oh!

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Unit Test Results

Unit Test Output

Uh oh!

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Static Analysis & Code Style Results

PHP Codesniffer Output

PHP Mess Detector Output

Uh oh!

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Functional Acceptance Test Results

PHP 7.2

PHP 7.3

PHP 7.4

Uh oh!

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

PHP 7.4 AcceptanceCeCest Output

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants