[SPM] Implement SP//dr, Piloted by Peni #13876
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayDi85
reviewed
Jul 24, 2025
| cards.add(new SetCardInfo("Plains", 194, Rarity.LAND, mage.cards.basiclands.Plains.class, NON_FULL_USE_VARIOUS)); | ||
| cards.add(new SetCardInfo("Risky Research", 62, Rarity.COMMON, mage.cards.r.RiskyResearch.class)); | ||
| cards.add(new SetCardInfo("Romantic Rendezvous", 86, Rarity.COMMON, mage.cards.r.RomanticRendezvous.class)); | ||
| cards.add(new SetCardInfo("SP//dr, Piloted by Peni", 147, Rarity.UNCOMMON, mage.cards.s.SPDrPilotedByPeni.class)); |
There was a problem hiding this comment.
It's better to replace by some symbols like ii (like other non ascii card names does). There are possible many problems including system file names, import, card naming, etc.
There was a problem hiding this comment.
Also there are much more places with "//" usage to check/fix:
There was a problem hiding this comment.
maybe we just change it to SP/dr since a single slash isn't a problem
There was a problem hiding this comment.
If you change the name internally, make sure it works with deck imports from the various importers.
There was a problem hiding this comment.
No needs in single /. Maybe it's better to add // support, but it require addition unit and manual tests with it.
Possible places to check/improve:
- deck editor's deck save and load with that card (possible problems: unknown card or wrong layout error);
- deck editor's import from clipboard/text, deck's import from another formats (possible problems: unknown card);
- deck editor's searching (possible problems: can't find card name);
- image's download from gatherer (possible problems: can't find card image, can't save);
- image's download from scryfall (possible problems: can't find card image, can't save);
- image's download from custom scryfall like cards/tokens (possible problems: can't find image, can't save);
- gui's drawring (possible problems: can't load card image);
- gui's m15 render mode (possible problems: wrong name or type drawing);
- game's card name searching/lookup for name choosing in the ability, e.g. choose dialog (possible problems: can't see card name in the list);
- game's same card name compare, e.g. ability's effect to find same card name (possible problems: can't find card with same name);
- test's same card name compare (possible problems: can't find card with same name);
- test's addCard, cast, setChoice/Target with that name (possible problems: can't find card with that name);
JayDi85
changed the title
theelk801
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The card itself is fine, I just wanna make sure we're handling the
//in the name correctly.tracking #13875