Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in Sharae of Numbing Depths #13176

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Conversation

padfoothelix
Copy link
Contributor

The bug caused Sharae's ability to trigger even when her owner's permanents got tapped.

@github-actions github-actions bot added the cards label Dec 22, 2024
Copy link
Contributor

@Grath Grath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style nitpick: space after each comma in the call to match.

@padfoothelix
Copy link
Contributor Author

Thanks for the correction. I also left the original line which caused the bug commented, which is kinda ugly, but I wasn't too sure of myself since this is the first time I change the code on a card. Should I clean and do another PR ?

@Grath
Copy link
Contributor

Grath commented Dec 22, 2024

You can delete the original line and fix the spacing, then push your code again and it will update this pull request.

@padfoothelix
Copy link
Contributor Author

Thanks ! It's done.

@Grath Grath merged commit f4eeda7 into magefree:master Dec 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants