[don't merge] Refactoring - Code style issues - C-style array declaration #13173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
approved these changes
Dec 22, 2024
JayDi85
changed the title
|
Don't merge. There are related and interesting old AI related code with block simulation (hidden by another implementation), I need some research about it before removing or keep it (bytes copy used in one place only). |
|
How could this possibly be a problem? It's functionally equivalent code. |
|
It's not a problem -- just interesting found with hidden code that can potentially improve many combat problems with AI including chump blocking #4485. I don't want to forget about it. P.S. Outdated or unused code must be removed instead fixed. Current PR fixed unused code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.jetbrains.com/help/inspectopedia/CStyleArrayDeclaration.html