rework batch events #13066
Merged
rework batch events #13066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply for tapped, untapped, sacrificed, milled simplify Ob Nixilis, Captive Kingpin
rework some delayed triggered abilities
JayDi85
reviewed
Nov 17, 2024
xenohedron
added a commit
that referenced
this pull request
Dec 22, 2024
trigger on combat damage only, regression from #13066
4825764518
pushed a commit
to 4825764518/mage
that referenced
this pull request
Feb 17, 2025
trigger on combat damage only, regression from magefree#13066
4825764518
pushed a commit
to 4825764518/mage
that referenced
this pull request
Mar 7, 2025
trigger on combat damage only, regression from magefree#13066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the updated version of #12173.
Many new common classes for batch triggered abilities, which now use a more modular framework. Removed a variety of ad-hoc workarounds, deduplicated some code, and fixed various edge cases.
Before merge, I'll drop the hacky verify check. I'll also drop the tests that require test API updates; those can be a separate scope, but I did want to include just in case. (edit:done)Separate scope for followup: - Add new life lost by player from #12202
Fix #12193, fix #12095, resolves #13057, closes #12173