[MKC] Implement Unshakable Tail #11843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
approved these changes
Feb 24, 2024
| this.toughness = new MageInt(2); | ||
|
|
||
| // When Unshakable Tail enters the battlefield and at the beginning of your upkeep, surveil 1. | ||
| this.addAbility(new UnshakableTailSurveilTriggeredAbility()); |
There was a problem hiding this comment.
fyi we do have OrTriggeredAbility
|
|
||
| @Override | ||
| public String getRule() { | ||
| return "When {this} enters the battlefield and at the beginning of your upkeep, surveil 1."; |
There was a problem hiding this comment.
I prefer only overriding getRule when both the trigger and effect are unique, and the effect depends on the trigger. Otherwise, it's better to just setTriggerPhrase() in the constructor and let the effect text be generated automatically. This is easier to refactor, and auto text generation is preferred whenever possible because discrepancies in generated text can sometimes catch mistakes.
| } | ||
| } | ||
|
|
||
| class UnshakableTailInvestigateTriggeredAbility extends TriggeredAbilityImpl { |
There was a problem hiding this comment.
hm, could be common class at some point (Sidisi Brood Tyrant, Devourer of Memory)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11669