[MKM] Implement Flourishing Bloom-Kin and move Cultivate-like searches to common class #11837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
reviewed
Feb 23, 2024
...bilities/effects/common/search/SearchLibraryPutOneOntoBattlefieldTappedRestInHandEffect.java
Outdated
Show resolved
Hide resolved
| Card cardToBattlefield = revealed.get(targetCardToBattlefield.getFirstTarget(), game); | ||
| if (cardToBattlefield != null) { | ||
| controller.moveCards(cardToBattlefield, Zone.BATTLEFIELD, source, game, true, false, false, null); | ||
| revealed.remove(cardToBattlefield); |
There was a problem hiding this comment.
hm, what's the point of this remove()?
There was a problem hiding this comment.
It's there so that the card we just put onto the battlefield isn't moved to your hand along with the other cards later. I've rewritten this area a bit to try to make it easier to understand.
xenohedron
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed like a good idea to move Cultivate-like search effects to a common class, since we have a half-dozen cards doing that now.
Note: Flourishing Bloom-Kin does not fully function since Disguise is not yet implemented.