[MKM] Implement Intrude on the Mind #11825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
reviewed
Feb 21, 2024
| import mage.constants.CardType; | ||
| import mage.constants.SubType; | ||
|
|
||
| public class ThopterColorlessToken2 extends TokenImpl { |
There was a problem hiding this comment.
I prefer something more descriptive than tacking on a number, maybe "Thopter00ColorlessToken" ? Not critical
| if (opponent != null) { | ||
| game.informPlayers(controller.getLogName() + " chose " + opponent.getLogName() + " to choose the piles"); | ||
| } else { | ||
| game.informPlayers(controller.getLogName() + " chose nothing" + " to choose the piles"); |
There was a problem hiding this comment.
(idk why bother with info message on failed choice, shouldn't happen in normal usage)
There was a problem hiding this comment.
ah you still need to null check it though
| staticText = "Reveal the top five cards of your library and separate them into two piles. " + | ||
| "An opponent chooses one of those piles. Put that pile into your hand and the other into your graveyard. " + | ||
| "Create a 0/0 colorless Thopter artifact creature token with flying, " + | ||
| "then put a +1/+1 counter on it for each card put into your graveyard this way."; |
There was a problem hiding this comment.
Wow cards these days have so much text. It's unfortunate this has to duplicate logic from the existing class but given the constraints this custom class does seem to be the way to go.
xenohedron
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11516