Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MKM] Implement Karlov Watchdog #11820

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

DominionSpy
Copy link
Contributor

@github-actions github-actions bot added the cards label Feb 19, 2024
@Override
public boolean applies(GameEvent event, Ability source, Game game) {
return game.isActivePlayer(source.getControllerId()) &&
game.getOpponents(source.getControllerId()).contains(event.getPlayerId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. You want to check the controller of the object, and that's not necessarily the same as event.getPlayerId() if you check how it is used (unfortunately no description in GameEvent.EventType so have to look at where it's fired in CardImpl::turnFaceUp)

As coded here, this corresponds to "your opponents can't turn permanents face up during your turn" so if someone chose to play Break Open then the interaction would be incorrect

@xenohedron xenohedron merged commit 4ce2e7d into magefree:master Feb 22, 2024
1 of 2 checks passed
@DominionSpy DominionSpy deleted the karlov-watchdog branch February 22, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants