Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MKC] Implement Mirko, Obsessive Theorist #11813

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

PurpleCrowbar
Copy link
Member

I tried hard to get the text to generate nicely but I believe the use of the target adjuster was causing rules generation issues, and setting the rules text with setText resulted in excessively verbose instructions when resolving the ability, so I ended up using an info effect to spoof the rules text of the final ability. Other, less heavy-handed approaches all yielded inferior results, so this approach is prioritising UX at the cost of slight code elegance

@PurpleCrowbar
Copy link
Member Author

[[Mirko, Obsessive Theorist]]

Copy link

Mirko, Obsessive Theorist - (Gatherer) (Scryfall) (EDHREC)

{1}{U}{B}
Legendary Creature — Vampire Detective
1/3
Flying, vigilance
Whenever you surveil, put a +1/+1 counter on Mirko, Obsessive Theorist.
At the beginning of your end step, you may return target creature card with power less than Mirko's from your graveyard to the battlefield with a finality counter on it. (If it would die, exile it instead.)

Copy link
Contributor

@xenohedron xenohedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what the issue is with the text but I'll take your word for it that this is the best UX solution.

Thanks for the surveil triggered ability refactor.

@github-actions github-actions bot added the cards label Feb 18, 2024
@PurpleCrowbar
Copy link
Member Author

I'll show what I mean by the text issue for the last ability.

No info effect and no setText call

Rules text (note that the text is not at all accurate to the real card):
image
When choosing to take the action while resolving the ability:
image

No info effect but setText is called

Rules text (note that it is correct):
image
When choosing to take the action while resolving the ability (note the extremely verbose message):
image

Using info effect, hiding real ability rules text (implementation in this PR)

Rules text (note that it is correct, as in the case of the second approach):
image
When choosing to take the action while resolving the ability (note it's succinct, as in the case of the first approach):
image

The final approach gets the best text / prompts.

@JayDi85
Copy link
Member

JayDi85 commented Feb 20, 2024

Don’t use text effect here: its hide original ability and potential text problems with it, and adds new code to support. Its ok to have “strange” text in dialogs. setText is standard code style.

Text effects created for additional information or outside abilities/effects.

Ability ability = new BeginningOfYourEndStepTriggeredAbility(
new ReturnFromGraveyardToBattlefieldWithCounterTargetEffect(CounterType.FINALITY.createInstance()),true
);
ability.setTargetAdjuster(MirkoObsessiveTheoristAdjuster.instance);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at GracefulRestoration - it uses target filter without adjuster. Why not use same way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe like EarthshakerKhenraPredicate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a custom predicate and setText as in the case with Earthshaker Khenra:
Rules text:
image
Target text:
image
Confirming resolution:
image

The resolution confirming is still wordy but presumably consistent with other cards so not important

@PurpleCrowbar
Copy link
Member Author

Verify fail appears to be unrelated to this PR

@xenohedron xenohedron merged commit 201edec into magefree:master Feb 21, 2024
3 of 4 checks passed
@PurpleCrowbar PurpleCrowbar deleted the mirko-obsessive-theorist branch February 21, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants