[WHO] Implement TARDIS #11803
Merged
[WHO] Implement TARDIS #11803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
requested changes
Feb 17, 2024
|
I think all the changes requested were made, I'm confused why the hint needs to be a part of the ability though and not it's own, is that just a style thing? |
xenohedron
approved these changes
Feb 21, 2024
|
Hints are associated with abilities, and style is definitely to use existing abilities and not make fake ones to store hints. Card view will collect all hints and display appropriately below all ability text. |
|
Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10653
First pull request, let me know if any issues :)