-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MKM] Implement Kaya, Spirits' Justice and new zone change batch event #11753
Conversation
Mage.Tests/src/test/java/org/mage/test/cards/single/mkm/KayaSpiritsJusticeTest.java
Show resolved
Hide resolved
So what is the difference between Code looks fine now, just want to make sure documentation is clear for future devs. |
For example, paying a Craft cost by exiling a creature permanent and a card from your graveyard would fire 1 |
|
||
for (UUID playerId : game.getState().getPlayersInRange(ability.getControllerId(), game)) { | ||
Player player = game.getPlayer(playerId); | ||
if (player == null || player == controller) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compare UUID with equals rather than player objects
ZONE_CHANGE_GROUP and related usages will be replaced by ZONE_CHANGE_BATCH in the future (group event has buggy/wrong logic and duplicate events in some use cases). Batch logic is correct. |
#11516