-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game under control doesn’t work (Emrakul, the Promised End and other) #12878
Comments
[[Emrakul, the Promised End]] |
Emrakul, the Promised End - (Gatherer) (Scryfall) (EDHREC)
|
It’s can be related to wrong usage of user’s skip settings in HumanPlayer.java |
I mean the game can use pressed skip button and skip user settings from wrong player (not from real controller of the player). I added some todos about it somewhere in HumanPlayer long ago. Same bugs with miss priority can be appear after rollback with active skip buttons (maybe). |
Also AI code can be bugged with under control effects (related to same problems with wrong usage of real controller). |
Sen Triplets is screwed up as well. May be related or not. #12918 |
I can confirm: turn control effects doesn’t work at all in human games. And your opponent must press skip button to continue without any actions (or you will lose by timeout). There are impossible to play/activate anything. And it’s not related to any settings. |
AI games also affected -- you can't do anything and can only pass priority. |
- game: added support for human games (cards like Emrakul, the Promised End, #12878); - game: added support of 720.1. to reset control in the turn beginning instead cleanup step (related to #12115); - game: added game logs for priorities in cleanup step; - game: fixed game freezes and wrong skip settings usages (related to #12878); - gui: added playable and choose-able marks for controlling player's cards and permanents, including switched hands; - gui: added controlling player name in all choice dialogs; - info: control of computer players is it not yet supported;
Added support of under control effects for human games in c076f49, cards like Emrakul, the Promised End are fully playable without game freeze. Also it contains some other game freeze fixes and gui improves. Computer players doesn't support it yet. Maybe I'll add it later ( |
Old issue with more details: |
- game: added support when a human is take control over a computer player (related to #12878); - game: fixed game freezes while controlling player leaves/disconnect on active priority/choose of another player;
Take control over computer player added by 0505f51. Now you can fully control computer's actions. It can be useful for test mode too (use cheats menu to take control over computer and setup attack/defend/casts/etc instead using two client apps). P.S. There's one last feature left to develop: computer take control over another computer or human. It will use pass and default choice logic due too complicated use cases. |
- game: fixed game freezes when computer try to take control over another computer or human (added game logs, related to #12878); - cheats: improved take and give control commands, now you can give control under yourself to another player; - cheats: improved take and give control commands, now you can return control to computer in the same priority; - cheats: deleted useless and unused command to activate opponent's ability;
After casting Emrakul, the Promised End, I can‘t control my opponent's turn.(It doesn't work after I switch)
This is a bug,Hope you can fix it perfectly.THX!
The text was updated successfully, but these errors were encountered: