Skip to content

Commit

Permalink
[UGL] remove "Elves" subtype from Elvish Impersonators
Browse files Browse the repository at this point in the history
  • Loading branch information
@theelk801
theelk801 committed Jun 19, 2023
1 parent ae94db9 commit 1be43ef
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Mage.Sets/src/mage/cards/e/ElvishImpersonators.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public final class ElvishImpersonators extends CardImpl {

public ElvishImpersonators(UUID ownerId, CardSetInfo setInfo) {
super(ownerId, setInfo, new CardType[]{CardType.CREATURE}, "{3}{G}");
this.subtype.add(SubType.ELVES);
this.subtype.add(SubType.ELF);
this.power = new MageInt(0);
this.toughness = new MageInt(0);

Expand Down
2 changes: 2 additions & 0 deletions Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ public class VerifyCardDataTest {
// subtype
skipListCreate(SKIP_LIST_SUBTYPE);
skipListAddName(SKIP_LIST_SUBTYPE, "UGL", "Miss Demeanor"); // uses multiple types as a joke card: Lady, of, Proper, Etiquette
skipListAddName(SKIP_LIST_SUBTYPE, "UGL", "Elvish Impersonators"); // subtype is "Elves" pun
skipListAddName(SKIP_LIST_SUBTYPE, "UND", "Elvish Impersonators");

// number
skipListCreate(SKIP_LIST_NUMBER);
Expand Down
1 change: 0 additions & 1 deletion Mage/src/main/java/mage/constants/SubType.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ public enum SubType {
ELEMENTAL("Elemental", SubTypeSet.CreatureType),
ELEPHANT("Elephant", SubTypeSet.CreatureType),
ELF("Elf", SubTypeSet.CreatureType),
ELVES("Elves", SubTypeSet.CreatureType, true), // Un-sets
ELK("Elk", SubTypeSet.CreatureType),
EMPLOYEE("Employee", SubTypeSet.CreatureType),
EYE("Eye", SubTypeSet.CreatureType),
Expand Down

4 comments on commit 1be43ef

@Grath
Copy link
Contributor

@Grath Grath commented on 1be43ef Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this done? The official Oracle text still lists the creature type as Elves, and that was updated in 2020 when they did Unsanctioned. I don't see anything listing that the creature type has been changed.

@theelk801
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's an elf and should be affected by anything that affects elves but it's silver-bordered so its subtype is a pun

@xenohedron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's not an Elf actually; it's an Elves

@theelk801
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guarantee you mark rosewater would rule that it's an elf for all intents and purposes

Please sign in to comment.