Skip to content

Commit

Permalink
Changeling - improved combo support for creature type triggers and ch…
Browse files Browse the repository at this point in the history
…angeling spells (example: Volo, Itinerant Scholar) (#11569)
  • Loading branch information
xenohedron authored Dec 23, 2023
1 parent 3bc9999 commit 1737a0a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import mage.game.stack.Spell;
import mage.players.Player;

import java.util.HashSet;
import java.util.LinkedHashSet;
import java.util.Set;
import java.util.stream.Collectors;

Expand All @@ -32,7 +32,7 @@ public VolosJournalToken() {
).addHint(VolosJournalTokenHint.instance));
}

protected VolosJournalToken(final VolosJournalToken token) {
private VolosJournalToken(final VolosJournalToken token) {
super(token);
}

Expand All @@ -42,13 +42,13 @@ public VolosJournalToken copy() {

public static Set<String> getNotedTypes(Game game, Permanent permanent) {
if (permanent == null) {
return new HashSet<>();
return new LinkedHashSet<>();
}

String key = "notedTypes_" + permanent.getId() + '_' + permanent.getZoneChangeCounter(game);
Object value = game.getState().getValue(key);
if (value == null) {
Set<String> types = new HashSet<>();
Set<String> types = new LinkedHashSet<>();
game.getState().setValue(key, types);
return types;
}
Expand Down
4 changes: 3 additions & 1 deletion Mage/src/main/java/mage/game/stack/Spell.java
Original file line number Diff line number Diff line change
Expand Up @@ -1129,15 +1129,17 @@ public void createSingleCopy(UUID newControllerId, StackObjectCopyApplier applie

@Override
public boolean isAllCreatureTypes(Game game) {
return false;
return card.isAllCreatureTypes(game);
}

@Override
public void setIsAllCreatureTypes(boolean value) {
card.setIsAllCreatureTypes(value);
}

@Override
public void setIsAllCreatureTypes(Game game, boolean value) {
card.setIsAllCreatureTypes(game, value);
}

@Override
Expand Down

0 comments on commit 1737a0a

Please sign in to comment.