Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xh] Copy croniter library into shared repo #5703

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[xh] Copy croniter library into shared repo #5703

wants to merge 2 commits into from
+3,943 −5

Conversation

matrixstone
Copy link
Collaborator

Description

Copy the croniter library into the shared repository following the bug report: mage-ai/mage-ai#5684, as it will no longer be maintained.

How Has This Been Tested?

Unit test passed:

test_scheduler:
unit test

test_croniter:
test_croniter

Tested schedule run in Mage UI:
schedule run

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:
@wangxiaoyou1993

@matrixstone matrixstone added the bug Something isn't working label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxiaoyou1993 wangxiaoyou1993 Awaiting requested review from wangxiaoyou1993

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matrixstone