Migrate to rsbuild #737
Merged
Migrate to rsbuild #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encounter
commented
Dec 25, 2024
| @@ -116,7 +116,7 @@ class DataFetcherRequest { | |||
| public async start() { | |||
| this.started = true; | |||
|
|
|||
| if (this.cache !== null) { | |||
| if (!IS_DEVELOPMENT && this.cache !== null) { | |||
There was a problem hiding this comment.
I added this because it will aggressively cache in dev server mode, even when using empty cache + reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsbuild wraps rspack and provides a more batteries-included solution. This provides a large reduction in Node deps and a simpler configuration schema.
I added various comments to
rsbuild.config.ts, let me know if anything is unclear.Note: thedatadir was moved topublic/data, along withdist/.htaccess->public/.htaccess. This works better with the built-in dev server and production build logic. If undesired,public/datacould be a symlink to../data, so that devs don't have to move their dir.public/data/is now symlinked todata/.