Implement d_wood (bushes) for Wind Waker #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already exist Without this change, the script will fail if data/ZeldaWindWaker does not already exist
NoClip expects these files to be present in the output directory.
This should be everything we need to render bushes
This is the start of one of the remaining missing d_s_play components, Wood (which is the TWW misnomer for bushes). Instead of following the old Grass.ts pattern, this is architected as similar to the d_wood.cpp as possible. This makes it simpler to compare to the decompiled results. A few functions are implemented, and the rendering is based heavily off of d_tree so it may not be completely correct. But basic model rendering and drop shadows are present.
This is used by d_wood's animation functions
Since the src and dst parameters are switched from usual, I think it's worth adding this so that it's easy to copy paste from decomp
Idle animation fully implemented
* Enable alpha testing on bushes (greatly improves aliasing on leaf edges) * Render to the XLU BG display list. This fixes an ordering issue. We must render after most bg objects because of the alpha testing. * Disable alpha test when fading out after a bush has been cut
magcius
reviewed
Oct 22, 2024
| scratchMat4a[12] += this.mPos[0]; | ||
| scratchMat4a[13] += this.mPos[1]; | ||
| scratchMat4a[14] += this.mPos[2]; | ||
| mat4.mul(this.mModelViewMtx, globals.camera.viewMatrix, scratchMat4a); |
There was a problem hiding this comment.
Probably easier to construct the MVM at prepareToRender time and just add animation/model matrices in here.
There was a problem hiding this comment.
Ah I'm just matching what the cpp was doing, so I'm more confident I don't miss anything. Should I move it around? Got a preference?
This reverts commit a28b3f5.
Also name the last of the unknown variables
The implementation is identical in JS (in C++ it's the short version vs float)
Removes old hardcoded texcoord hack
magcius
reviewed
Oct 24, 2024
magcius
reviewed
Oct 24, 2024
|
Yea thanks for the thorough review! It's been so long, I'd like to match your vision as best I can. Rather have all the nits up front 😁 |
This differes from the cpp, but suits JS better
magcius
reviewed
Oct 24, 2024
magcius
reviewed
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full rendering support, as well as idle and cut animation support. This is picking up from a changelist I stashed 5 years ago 😂