BfBB: Fix memory leaks (#719)

* BfBB: Fix memory leaks

* Fix models referencing destroyed textures

src/HeavyIron/HIScene.ts

@@ -191,6 +191,8 @@ export class HIScene implements SceneGfx {
             texture.destroy(this.rw);
         }
 
+        this.env.jsp.destroy(this.rw);
+
         this.rw.destroy();
     }
 
@@ -379,6 +381,10 @@ export class HIScene implements SceneGfx {
 
     private loadTexture(asset: HIPAsset): boolean {
         if (asset.data.byteLength === 0) return true;
+
+        // Don't load duplicate textures, temporary hack to prevent memory leaks
+        // TODO: Have each asset keep track of their own runtime data like in the OG game
+        if (this.textures.has(asset.id)) return true;
 
         const stream = new RwStream(asset.data);
         if (!stream.findChunk(RwPluginID.TEXDICTIONARY)) {
@@ -388,8 +394,14 @@ export class HIScene implements SceneGfx {
 
         const texDict = RwTexDictionary.streamRead(stream, this.rw);
         if (!texDict) return false;
+
+        // We only use the first texture
+        const texture = texDict.textures[0];
+        texDict.removeTexture(texture);
+
+        texDict.destroy(this.rw);
 
-        this.textures.set(asset.id, texDict.textures[0]);
+        this.textures.set(asset.id, texture);
         return true;
     }
 

src/HeavyIron/JSP.ts

@@ -85,4 +85,10 @@ export class JSP {
             stream.pos = header.end;
         }
     }
+
+    public destroy(rw: RwEngine) {
+        for (const node of this.nodeList) {
+            node.atomic.destroy(rw);
+        }
+    }
 }

src/HeavyIron/rw/rwcore.ts

@@ -466,6 +466,19 @@ export class RwTexDictionary {
 
         return texDict;
     }
+
+    public destroy(rw: RwEngine) {
+        for (const texture of this.textures) {
+            texture.destroy(rw);
+        }
+    }
+
+    public removeTexture(texture: RwTexture) {
+        const index = this.textures.indexOf(texture);
+        if (index !== -1) {
+            this.textures.splice(index);
+        }
+    }
 }
 
 export class RwFrame {