-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few missing endpoints and bug fixes #20
Merged
Vardominator
merged 9 commits into
maestro-org:main
from
book-io:add-some-missing-endpoints
Mar 19, 2024
Merged
Add a few missing endpoints and bug fixes #20
Vardominator
merged 9 commits into
maestro-org:main
from
book-io:add-some-missing-endpoints
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00kdev
commented
Mar 19, 2024
b00kdev
commented
Mar 19, 2024
b00kdev
commented
Mar 19, 2024
b00kdev
commented
Mar 19, 2024
b00kdev
commented
Mar 19, 2024
b00kdev
commented
Mar 19, 2024
Vardominator
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Maestro! We appreciate your effort and dedication to improving this project. To ensure that your contribution is in line with the project's guidelines and can be reviewed efficiently, please fill out the template below.
Remember to follow our Contributing Guide before submitting your pull request.
Summary
When attempting to use the Rust SDK, I found a few endpoints I needed to use were not implemented. As well, a few endpoints I tried to use failed at runtime due to bad types in the model or invalid endpoint URLs. This PR addresses those things.
Type of Change
Please mark the relevant option(s) for your pull request:
Checklist
Please ensure that your pull request meets the following criteria:
NOTE: I do not actually see any tests, so have not added any to my changes.
Testing
No tests were added
Additional Information
I did add a couple of dependencies. I'm not sure if you want to take these or if maybe they should be feature flags on the crate.