Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to GitHub Actions #95

Merged
merged 3 commits into from
Nov 16, 2020
Merged

chore: migrate to GitHub Actions #95

merged 3 commits into from
Nov 16, 2020

Conversation

hndoss
Copy link
Contributor

@hndoss hndoss commented Oct 18, 2020

What kind of change does this PR introduce?

E2E and Linting in CI/CD on every push or Pull Request.

Did you add tests for your changes?
No.

If relevant, did you update the documentation?
No.

Summary
It solves issue #94

Does this PR introduce a breaking change?

No.

Other information

@welcome
Copy link

welcome bot commented Oct 18, 2020

Thanks for opening this pull request! Please check out our contributing guidelines.

Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to run tests across multiple OS, preferably using a build matrix.

@jamesgeorge007
Copy link
Member

jamesgeorge007 commented Oct 21, 2020

You can refer to madlabsinc/mevn-cli#190

@jamesgeorge007 jamesgeorge007 changed the title chore: add GitHub Actions lint pipeline chore: migrate to GitHub Actions Nov 16, 2020
@jamesgeorge007 jamesgeorge007 linked an issue Nov 16, 2020 that may be closed by this pull request
@jamesgeorge007 jamesgeorge007 merged commit ca6c3ec into madlabsinc:next Nov 16, 2020
@welcome
Copy link

welcome bot commented Nov 16, 2020

congrats
Congrats on your very first contribution 👏 Looking forward to having more from your side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate to GitHub Actions
2 participants