Change sync service url #472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowlicks
force-pushed
the
change-sync-service-url
branch
from
c421e5d to
1e4d10d
Compare
Member
|
@cowlicks can you please rn a biome check on the infra folder to format your PR. |
whutchinson98
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to change the URL for sync service for the dev deployment. Throughout the code we assume there is a structure to the hostname's for our services. They look like:
blah-blah-service-prod.comfor prodblah-blah-service-dev.comfor dev. This change breaks that assumption for sync service. FWIW I think we would be better off treating service URL's as as opaque strings instead of doing this.Some possible issues with this PR:
js/lexical-service/src/lib/sync-service.tsI don't understand how this was working before. So maybe I'm missing something.