Non-root cargo manifest file #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macisamuele
approved these changes
Mar 31, 2024
auto-merge was automatically disabled
March 31, 2024 17:54
Base branch was modified
|
I've fixed the tests passing & rebase to the latest master changes. @macisamuele, recheck the PR, please |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 336 337 +1
=========================================
+ Hits 336 337 +1 ☔ View full report in Codecov by Sentry. |
macisamuele
reviewed
Apr 2, 2024
| filename = os.path.abspath(filename) | ||
|
|
||
| manifest_file = os.path.join(manifest_root, "Cargo.toml") | ||
| print(manifest_file) |
There was a problem hiding this comment.
please remove prints from tests
macisamuele
approved these changes
Apr 2, 2024
auto-merge was automatically disabled
April 2, 2024 08:12
Head branch was pushed to by a user without write access
|
All was fixed & updated. CI is also green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should implement & fix #210