Open
Conversation
d42f221 to
2128971
Compare
tleguijt
reviewed
Jul 2, 2025
| allow_component_not_found: | ||
| description: "Allow component not found in MCC. This will cause the component to always be marked as changed." | ||
| required: false | ||
| default: "false" |
There was a problem hiding this comment.
shouldn't the default just be true?
It won't break any of the existing functionality I suppose
Contributor
Author
There was a problem hiding this comment.
It might cause some unexpected side effect. Without it will just pipe down the error to a later stage when building and registering the component happens. This would probably break in a run on main instead. That is obviously fixable by adding the --create-component flag in mach, but I don't know if we want that to happen as a default now?
2128971 to
9d5b522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces code improvements and new functionality to enhance maintainability and flexibility. The most important changes include enforcing consistent formatting, adding a new input parameter
allowComponentNotFound, and updating the MCC client to handle missing components gracefully.Code Formatting and Consistency:
src/check.tsfile. [1] [2] [3] [4]dependenciesmapping ingetTurboChangedPackages.getTurboPlanto use double quotes for consistency.New Input Parameter:
allowComponentNotFoundboolean input to theInputstype and updated thereadInputsfunction to read this value from the workflow inputs. [1] [2]allowComponentNotFoundparameter to thegetLatestVersionmethod insrc/main.ts.MCC Client Enhancements:
getLatestVersionmethod in the MCC client to accept theallowComponentNotFoundparameter.allowComponentNotFoundis true, logging a warning instead of throwing an error.