-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-flatness check #54
Conversation
Could you merge the latest main branch into the PR? The tests failed due to a deprecated version of |
The SMARTS do not seem completely correct yet. Could the |
If I understand SMARTS correctly, capital letters match only aliphatic atoms and hence we can drop the
|
Good to know, I didn't check it. Updated the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank you very much for your contribution. |
Addresses this issue #53
Adds a non-flatness check for non-flat 5- and 6-membered rings with the following SMARTS patterns