feat: highcharts configs #534
Conversation
src/constants/ChartConfig.ts
Outdated
| color: 'rgba(56, 60, 67, 0.7)', | ||
| } as const | ||
|
|
||
| export const ChartConfig = { |
There was a problem hiding this comment.
Can we add a type for this?
There was a problem hiding this comment.
hopefully!
yes we can def add a type from Highcharts, but i didnt yet (in 2 minutes) find a highcharts type-only package. we do not want to add all of highchairs to the aquarium, only the types
There was a problem hiding this comment.
Hmm I wonder if we could just add the highcharts package and rely on vite's tree-shaking? https://vite.dev/guide/features#named-imports
There was a problem hiding this comment.
great point, added!
|
| @@ -87,6 +87,7 @@ | |||
| "wait-on": "7.2.0" | |||
| }, | |||
| "optionalDependencies": { | |||
| "@esbuild/darwin-x64": "0.24.2", | |||
There was a problem hiding this comment.
necessary to build locally for linking into nancy on my mac 🤷
| export const ChartColors: string[] = [0, -42, 37, -69, 62] | ||
| .map(alpha => Object.values(chartBaseColors).map(hex => shadeColor(hex, alpha))) | ||
| .flat() | ||
|
|
There was a problem hiding this comment.
taken from analytics, this creates an array of 100 colors from the original 20, with darker and ligher shades applied
| @@ -64,6 +64,7 @@ | |||
| "eslint-plugin-react-hooks": "4.6.0", | |||
| "factory.ts": "1.4.1", | |||
| "http-server": "14.1.1", | |||
| "highcharts": "12.1.2", | |||
There was a problem hiding this comment.
installed for Options type, other features tree shaken out by vite
# [1.38.0-chore-update-upload-artifact.1](v1.37.2...v1.38.0-chore-update-upload-artifact.1) (2025-01-31) ### Features * highcharts configs ([#534](#534)) ([588bebe](588bebe))
|
🎉 This PR is included in version 1.38.0-chore-update-upload-artifact.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [1.38.0](v1.37.2...v1.38.0) (2025-01-31) ### Features * highcharts configs ([#534](#534)) ([588bebe](588bebe))
|
🎉 This PR is included in version 1.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
TODO: REFERENCE PRS
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)