Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: double scroll on Table #530

Merged
merged 6 commits into from
Jan 17, 2025
Merged

fix: double scroll on Table #530

merged 6 commits into from
Jan 17, 2025
+48 −3

Conversation

danielsiemens
Copy link
Collaborator

Summary

  • Creates a new story for a Table with Fixed Header/Sticky Columns (to mimic functionality where this issue was observed)
  • Adds CSS to hide scrollbars when sticky is true:
    • Hides the horizontal scroll on the table itself
    • Hides an additional horizontal scrollbar that would only show on vertical scroll

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Tested and validated on Chrome, Firefox, Safari

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-17 23:23 UTC

tibuurcio
tibuurcio approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@tibuurcio tibuurcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested on PR env. className override also looks good.

@danielsiemens danielsiemens merged commit 2ae5258 into main Jan 17, 2025
9 checks passed
mparticle-automation added a commit that referenced this pull request Jan 22, 2025
@mparticle-automation
chore(release): 1.37.1 [skip ci]
09776eb 
## [1.37.1](v1.37.0...v1.37.1) (2025-01-22)

### Bug Fixes

* double scroll on Table ([#530](#530)) ([2ae5258](2ae5258))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.37.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibuurcio tibuurcio tibuurcio approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielsiemens @mparticle-automation @tibuurcio