Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Arduino Compile Errors #61

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Fixed Arduino Compile Errors #61

merged 3 commits into from
Aug 23, 2024

Conversation

LaikaSpaceDawg
Copy link
Contributor

Arduino compile errors were caused by updates to ESP_IDF and ESP32 Core.

Migrated Speaker.cpp to V3.0.0 standards following the migration guide here:
https://github.com/espressif/arduino-esp32/blob/master/docs/en/migration_guides/2.x_to_3.0.rst#ledc

Fixed GPIO errors by including hal/gpio_ll.h in In_eSPI.h to return access to utilized GPIO struct.

Includes GPIO hal layer to fix compile errors caused by GPIO struct being hidden by espressif
@LaikaSpaceDawg
Copy link
Contributor Author

Speaker.cpp updates may not be needed yet, V3.0.0 is not yet integrated in the official M5Stack toolchain, however it is in the newest ESP32 Core, which also includes the M5Stack for arduino, and is just as compatible a toolchain.

@imliubo imliubo requested a review from Tinyu-Zhao August 22, 2024 01:42
@Tinyu-Zhao
Copy link
Collaborator

Thank you for your help. We will take into account the old version while upgrading.

@Tinyu-Zhao Tinyu-Zhao merged commit 19afb52 into m5stack:master Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants