Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE: fix subtract with overflow in TE header parser #452

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

kkent030315
Copy link
Contributor

Fixed subtract with overflow in TE header parser and added regression test for it.

co-authored-by: dapa <dapa@github>
kkent030315 added a commit to kkent030315/goblin-experimental that referenced this pull request Mar 26, 2025
@m4b
Copy link
Owner

m4b commented Apr 6, 2025

alas, too many PRs acrued (mea culpa), and this will need a rebase unfortunately, sorry! and thank you for your contributions and patience :)

@kkent030315
Copy link
Contributor Author

@m4b done! and sorry, perhaps I should have made all crushed into single PR.

Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat thanks for rebasing !

@m4b m4b merged commit 8fda7a8 into m4b:master Apr 8, 2025
6 checks passed
@m4b
Copy link
Owner

m4b commented Apr 8, 2025

NB: non breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants