Notebook functionise plotting

[isaacaka]

This PR is to functionise the plotting code which is in the Jumper.ipynb notebook:

• Updates notebook to reflect refactored codebase
• Functionise plotting code in Jumper.ipynb located in a new file, plotting_utils.py. The plotting logic remains unchanged.
• Fix linting issues

Closes #93

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[ma595]

Hi Isaac, this is easier to follow, thanks.

Just a few points:

• Can you check if all the imports are used, i.e. plt, os?
• Do our linting checks actually check these files? If not, can you please add this.
• Is there an option to enable you to plot more components for visualisation purposes in the first two rows of the first figure?
• There seems to be a rogue blank plot in the plot_rmse_depth_profile function..
• We definitely need more comments in the Jupyter notebook to explain what's going
  on. I also don't really understand what some of the plots are showing. In particular cell 24 and beyond. This can be left to a separate PR.
• There's some french in the plots i.e. train serie
• Also the plot dashed lines do not seem to run up to 30 inclusive for the training data. Is this correct?

[isaacaka]

• Can you check if all the imports are used, i.e. plt, os?

Those are no longer needed after the refactor, will remove them.

• Do our linting checks actually check these files? If not, can you please add this.

plotting_utils.py has the linting checks done on them. The linting checks is done for all files except specific ones I excluded. The Jumper notebook had been excluded while I refactored the codebase. I have removed the exclusion now.

• Is there an option to enable you to plot more components for visualisation purposes in the first two rows of the first figure?

Not currently, the functions in general are not fully parametrized. I have mostly kept them as is, bar functionising them for now. Plan to do this in step 3 (sub-issue #95) of issue #94

• There seems to be a rogue blank plot in the plot_rmse_depth_profile function..

Yes, will fixed

• We definitely need more comments in the Jupyter notebook to explain what's going
  on. I also don't really understand what some of the plots are showing. In particular cell 24 and beyond. This can be left to a separate PR.

Overall we are replacing this single notebook with a set of example notebooks, this will be done in step 5 of issue #94. I created a larger issue for this to track the work. It will make it easier to see where this PR fits in the overall plan.

• There's some french in the plots i.e. train serie

Yes, will add the 's'

• Also the plot dashed lines do not seem to run up to 30 inclusive for the training data. Is this correct?

Yes, it goes from 0 to 29 rather than 1 to 30, so 30 values in total.

[ma595]

Thanks for the fixes. Ready to merge.