Skip to content

Fix ffmpeg subtitle overlay#81

Open
Mashinow wants to merge 1 commit into
m1guelpf:mainfrom
Mashinow:main
Open

Fix ffmpeg subtitle overlay#81
Mashinow wants to merge 1 commit into
m1guelpf:mainfrom
Mashinow:main

Conversation

@Mashinow

Copy link
Copy Markdown

This update fixes the ffmpeg functionality and lets you add subtitles to your videos right away. I tested it on Windows 10, but I can't guarantee it'll work on other systems.

@what-the-diff

what-the-diff Bot commented May 20, 2024

Copy link
Copy Markdown

PR Summary

  • Improved File Handling in 'cli.py'
    The changes introduce a more robust way to handle filename without the extension. Originally, the base filename was grabbed but the methodology was not the most consistent. It now uses a specific function to ignore file extensions.

  • Streamline Video Stream Variable Naming
    We've improved code consistency by renaming the video stream variable from 'video' to 'stream'. All code lines that previously referred to 'video' now correctly refer to 'stream'.

  • Advanced Subtitles Addition to Video Stream
    Modifications have been made to the process of adding subtitles, making it easier and more efficient. By reshaping the code, it's now more direct and intuitive to add subtitles to the video stream.

  • Updated Video Saving Process
    The previous way of saving the subtitled video has been switched out. The combination of ffmpeg.output() and ffmpeg.run() now helps to save these videos with specific required options. This change enhances the efficiency of the video saving process.

@CptEngage

Copy link
Copy Markdown

working now in Windows 11 edit: forgot to pip uninstall auto-subtitle then pip install git+https://github.com/Mashinow/auto-subtitle.git@f91096d3ade2fb18f866ab7133e97558028e794c

Thank you Mashinow and brokeDude2901 very much for your post and your comments here. Literally my first try working with python ever. And I managed to run this cursed app. The main page instructions and previous forks and whatever... posts(?) didn't help. But your stuff here helped! Very enlightening. Big thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants