You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This update fixes the ffmpeg functionality and lets you add subtitles to your videos right away. I tested it on Windows 10, but I can't guarantee it'll work on other systems.
Improved File Handling in 'cli.py'
The changes introduce a more robust way to handle filename without the extension. Originally, the base filename was grabbed but the methodology was not the most consistent. It now uses a specific function to ignore file extensions.
Streamline Video Stream Variable Naming
We've improved code consistency by renaming the video stream variable from 'video' to 'stream'. All code lines that previously referred to 'video' now correctly refer to 'stream'.
Advanced Subtitles Addition to Video Stream
Modifications have been made to the process of adding subtitles, making it easier and more efficient. By reshaping the code, it's now more direct and intuitive to add subtitles to the video stream.
Updated Video Saving Process
The previous way of saving the subtitled video has been switched out. The combination of ffmpeg.output() and ffmpeg.run() now helps to save these videos with specific required options. This change enhances the efficiency of the video saving process.
working now in Windows 11 edit: forgot to pip uninstall auto-subtitle then pip install git+https://github.com/Mashinow/auto-subtitle.git@f91096d3ade2fb18f866ab7133e97558028e794c
Thank you Mashinow and brokeDude2901 very much for your post and your comments here. Literally my first try working with python ever. And I managed to run this cursed app. The main page instructions and previous forks and whatever... posts(?) didn't help. But your stuff here helped! Very enlightening. Big thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes the ffmpeg functionality and lets you add subtitles to your videos right away. I tested it on Windows 10, but I can't guarantee it'll work on other systems.