Skip to content

Make boolean flags store_true#42

Open
daz wants to merge 2 commits into
m1guelpf:mainfrom
daz:main
Open

Make boolean flags store_true#42
daz wants to merge 2 commits into
m1guelpf:mainfrom
daz:main

Conversation

@daz

@daz daz commented Mar 29, 2023

Copy link
Copy Markdown

This enables you to just use the flag --verbose instead of needing to set --verbose=true. Same with the other boolean flags.

@what-the-diff

what-the-diff Bot commented Mar 29, 2023

Copy link
Copy Markdown

PR Summary

  • 🔄 Output and SRT Options Update
    Change output_srt and srt_only options to use action="store_true", simplifying their usage.
  • 🔊 Verbose Setting Improvement
    Remove the default value for verbose and use action="store_true" for a cleaner implementation.
  • 📝 Minor Code Aesthetic
    Add a newline in the get subtitles function for better code readability.

@jytou

jytou commented Oct 6, 2024

Copy link
Copy Markdown

Was going to make the exact same changes. This would be easy to merge and real added value - although we have to be careful that it might break existing automated flows using the non-stored boolean version. Another way to do it is to simply keep the existing ones and add new, stored, ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants