Fix audio out of sync#33
Open
RapDoodle wants to merge 1 commit into
Open
Conversation
|
Owner
|
@RapDoodle Can you update this to use the newer |
[what-the-diff] what a lovely but completely useless chap you are 😉. Your contribution made no sense to this thread. Anyway, @RapDoodle I'm afraid the de-synchronization still happens despite the changes! |
|
Following the discussion here openai/whisper#1888 I was able to greatly improve accuracy by adding the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a similar issue described in #28, but my videos are in English. I suspect it is related to the variable framerates of the video's recording device.
After some debugging, it turns out the output
.wavaudio file is out of sync with the original video. Thus, I added the-async 1option toffmpegand it fixed the issue.Also, because
asyncis a reversed keyword in Python, I replaced the call toffmpegwithsubprocess.run.