Added option to force the language#14
Open
TeoColuccio wants to merge 2 commits into
Open
Conversation
|
works thx for nice commit <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be convenient to be able to force the language instead of having it established by the transcriber, as it sometimes makes mistakes.
I have seen that whisper uses the --language option for this very purpose, through the DecodeOptions you already use in the model.transcribe().
So I just added the option and setting of the args ["language"] variable for valid values.
Note that when checking conditions, the "model" comes last, so that it overrides the "language" option itself.