Skip to content

Added subtitle translation into other languages#103

Open
adills wants to merge 7 commits into
m1guelpf:mainfrom
adills:main
Open

Added subtitle translation into other languages#103
adills wants to merge 7 commits into
m1guelpf:mainfrom
adills:main

Conversation

@adills

@adills adills commented Oct 13, 2024

Copy link
Copy Markdown

Great code! I only added the ability to use deep_translator to take your extracted subtitle and run it through a new function to translate the text into a different language.

I tested it with my personal video on a MacBook Pro M1 Max. I ran this to test:

pipenv run auto_subtitle ~/Downloads/PXL_20241007_234301920.mp4 --language_out es --model medium --output_dir ..

I hope you pull this for others to use.

@what-the-diff

what-the-diff Bot commented Oct 13, 2024

Copy link
Copy Markdown

PR Summary

  • New Feature for Translating Subtitles
    The developer team has added a fantastic new feature in your command-line tool that allows users to translate the subtitles into their language of choice, improving accessibility. Supported languages include Spanish, with an easy-to-use command-line option (--language_out es).

  • Updated Setup and Requirements
    To ensure that this new translation feature works correctly, your team has also updated the necessary setup files (setup.py) and requirements (requirements.txt). This way, the program will automatically install deep_translator, a key software component that executes the translation functions.

  • Enhanced Core Functionality
    The part of the code responsible for processing subtitles has been changed to include the new translation function. This ensures that the added feature integrates smoothly with the existing application. This change contributes significantly to improving user experience, giving them content in the language they understand best.

@mvigerske

Copy link
Copy Markdown

Is there already a way to use this version? When I download the files and install the setup.py, it does not yet recognise "--language_out" as a possible parameter. Or how can I force the programme to use this version and not the one installed in my system Python? (Windows user)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants