Skip to content

Add source IP flag and implementation #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maybe-hello-world wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add source IP flag and implementation #89

maybe-hello-world wants to merge 2 commits into from

Conversation

@maybe-hello-world
Copy link

@maybe-hello-world maybe-hello-world commented Mar 9, 2023 •
edited by robertodauria
Loading

This PR adds a "source" flag to the ndt7 client to allow running the test on a specific interface.

This change is Reviewable

@coveralls
Copy link

coveralls commented Mar 9, 2023

Pull Request Test Coverage Report for Build 200

  • 4 of 13 (30.77%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 88.329%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/ndt7-client/main.go 4 13 30.77%
Totals Coverage Status
Change from base Build 192: -1.0%
Covered Lines: 719
Relevant Lines: 814
💛 - Coveralls

@pvouzis
Copy link

pvouzis commented Feb 12, 2025

Is this going to work on windows/mac/linux?

@maybe-hello-world
Copy link
Author

maybe-hello-world commented Feb 13, 2025

I tested it on linux only for our build, but I would expect it to work on mac and windows as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maybe-hello-world @coveralls @pvouzis