Go version Upgrade to 1.25, pmk 안정화 #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add validation to check cluster status before adding NodeGroup - Only allow NodeGroup addition when cluster status is Active - Display error message for Creating/Deleting status - Implement error handling for API failures - Add documentation in doc/fix folder
- Add null check for cluster response in getSelectedPmkData() - Replace alert with modal for better UX in getCluster() - Add toast notifications for error scenarios - Return error objects instead of undefined - Add try-catch blocks for exception handling - Update documentation with known issues and fixes
- Add updateAddNodeGroupButtonState() function following existing pattern - Enable/disable button based on cluster status (Active only) - Remove status check logic from addNewNodeGroup() - Update HTML to remove href and set initial disabled state - Add tooltip to show why button is disabled - Improve UX by preventing form flash before validation - Update documentation with UI/UX improvements
- Add toggleSubElement call to display NodeGroup form - Previously removed href caused no action on button click - Now form properly displays when button is clicked
- Replace toggleSubElement with window.location.hash - Follow existing pattern used by other section navigations - Fix issue where previous sections remained visible - Enable browser back button support
- Add connectionName and description to mappingTablePmkData - Add extractRegionFromConnection helper function - Add loadRegionListForNodeGroup to load region list from API - Add updateNodeClusterConnectionsByRegion for region change handling - Set Provider as fixed (disabled) with current cluster value - Load and display Region dropdown with API data (changeable) - Extract cluster provider and connectionName from selectedCluster - Update form to properly populate Provider and Region fields
- Change Region field from selectable to fixed (disabled) - Remove loadRegionListForNodeGroup() helper function - Remove updateNodeClusterConnectionsByRegion() helper function - Keep extractRegionFromConnection() for region string formatting - Both Provider and Region now show cluster info only (not editable) - Improve performance by removing unnecessary API calls - Align with API behavior (createNode does not use Provider/Region)
- Add providerName parameter to getSshKey() API function - Extract cluster provider in displayNewNodeForm() - Add queryParams with filterKey and filterVal when provider exists - Filter SSH Keys by provider (e.g., filterKey=providerName, filterVal=aws) - Maintain backward compatibility (provider parameter is optional)
…idation Feature/pmk nodegroup status validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go version Upgrade to 1.25
pmk 생성시 image search, nodegroup 추가 등에 편의기능 추가